Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update fl2sm2 chunk_length default param #266

Merged
merged 1 commit into from
Oct 11, 2024
Merged

chore: update fl2sm2 chunk_length default param #266

merged 1 commit into from
Oct 11, 2024

Conversation

CamiloInx
Copy link
Member

@CamiloInx CamiloInx commented Oct 11, 2024 •
edited
Loading

Description

  • Update the Florence2Sam2 video chunk_length default value from None to 3
  • The original model uses as default a value of 20 for chunk_length which in some cases can be a very large default value for the subsampled videos.

@CamiloInx CamiloInx self-assigned this Oct 11, 2024
dillonalaird
dillonalaird approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CamiloInx CamiloInx merged commit 7070114 into main Oct 11, 2024
8 checks passed
@CamiloInx CamiloInx deleted the chore/update-fl2sm2-default-param branch October 11, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillonalaird dillonalaird dillonalaird approved these changes

Assignees

@CamiloInx CamiloInx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CamiloInx @dillonalaird